From: Marco Trevisan (Treviño) <mail@3v1n0.net>
Date: Thu, 25 Apr 2019 19:29:45 +0000 (-0500)
Subject: keyring: Use bind_property for message and description values
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~845^2^2~201
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=51655be6a386d6782bcc453e2c904bdbd955fad4;p=gnome-shell.git

keyring: Use bind_property for message and description values

This code was commented out in commit 593b431 as it was causing a crash in gjs.

As per the [1] gjs fix, this can now be safely used again.

[1] https://gitlab.gnome.org/GNOME/gjs/merge_requests/289
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/510
---

diff --git a/js/ui/components/keyring.js b/js/ui/components/keyring.js
index 0d9f1e466..ab0793f54 100644
--- a/js/ui/components/keyring.js
+++ b/js/ui/components/keyring.js
@@ -23,20 +23,8 @@ var KeyringDialog = class extends ModalDialog.ModalDialog {
         this._content = new Dialog.MessageDialogContent({ icon });
         this.contentLayout.add(this._content);
 
-        // FIXME: Why does this break now?
-        /*
         this.prompt.bind_property('message', this._content, 'title', GObject.BindingFlags.SYNC_CREATE);
         this.prompt.bind_property('description', this._content, 'body', GObject.BindingFlags.SYNC_CREATE);
-        */
-        this.prompt.connect('notify::message', () => {
-            this._content.title = this.prompt.message;
-        });
-        this._content.title = this.prompt.message;
-
-        this.prompt.connect('notify::description', () => {
-            this._content.body = this.prompt.description;
-        });
-        this._content.body = this.prompt.description;
 
         this._workSpinner = null;
         this._controlTable = null;